Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildflags: make work on go 1.22 by reverting rangefunc usage #2978

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

jsternberg
Copy link
Collaborator

@jsternberg jsternberg commented Feb 10, 2025

Reverts the usage of rangefunc and attempts to keep the foundation of it in for when we move to go 1.23. We have downstream dependencies that aren't ready to move to go 1.23. We can likely move after go 1.24 is released.

Related to #2965 (comment).

Reverts the usage of rangefunc and attempts to keep the foundation of it
in for when we move to go 1.23. We have downstream dependencies that
aren't ready to move to go 1.23. We can likely move after go 1.24 is
released.

Signed-off-by: Jonathan A. Sternberg <[email protected]>
@jsternberg jsternberg force-pushed the rangefunc-go1.22-revert branch from d9f8168 to 3ae9970 Compare February 10, 2025 17:03
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah
Copy link
Member

thaJeztah commented Feb 10, 2025

@crazy-max any idea what's up with those BSD builds?

  ln -sf hack/Vagrantfile.freebsd Vagrantfile
  vagrant up --no-tty
  shell: /usr/bin/bash -e {0}
  env:
    SETUP_BUILDX_VERSION: edge
    SETUP_BUILDKIT_IMAGE: moby/buildkit:latest
    SCOUT_VERSION: 1.11.0
    REPO_SLUG: docker/buildx-bin
    DESTDIR: ./bin
    TEST_CACHE_SCOPE: test
    TESTFLAGS: -v --parallel=6 --timeout=30m
    GOTESTSUM_FORMAT: standard-verbose
    GO_VERSION: 1.23
    GOTESTSUM_VERSION: v1.9.0
    VAGRANT_FILE: hack/Vagrantfile.freebsd
Bringing machine 'default' up with 'libvirt' provider...
==> default: Box 'generic/freebsd14' could not be found. Attempting to find and install...
    default: Box Provider: libvirt
    default: Box Version: >= 0
==> default: Box file was not detected as metadata. Adding it directly...
==> default: Adding box 'generic/freebsd14' (v0) for provider: libvirt
    default: Downloading: https://vagrantcloud.com/generic/freebsd14

The box failed to unpackage properly. Please verify that the box
file you're trying to add is not corrupted and that enough disk space
is available and then try again.
The output from attempting to unpackage (if any):

bsdtar: Error opening archive: Unrecognized archive format
Error: Process completed with exit code 1.
Bringing machine 'default' up with 'libvirt' provider...
==> default: Box 'pygolo/openbsd7' could not be found. Attempting to find and install...
    default: Box Provider: libvirt
    default: Box Version: 7.5
==> default: Box file was not detected as metadata. Adding it directly...
You specified a box version constraint with a direct box file
path. Box version constraints only work with boxes from Vagrant
Cloud or a custom box host. Please remove the version constraint

@thaJeztah
Copy link
Member

For FreeBSD, I see there's also freebsd/FreeBSD-14.0-CURRENT, is that the 'official" one? https://portal.cloud.hashicorp.com/vagrant/discover/freebsd/FreeBSD-14.0-CURRENT

@crazy-max
Copy link
Member

@thaJeztah Not related yes see #2976

@crazy-max crazy-max merged commit f580211 into docker:master Feb 11, 2025
125 of 127 checks passed
@jsternberg jsternberg deleted the rangefunc-go1.22-revert branch February 11, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants